fix: resolve refs to definitions keys with percent-encoded characters - #871
Open
haoku123 wants to merge 1 commit into
Open
fix: resolve refs to definitions keys with percent-encoded characters#871haoku123 wants to merge 1 commit into
haoku123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #740.
Problem
When a
definitions(or ``) key contains percent-encoded characters (e.g.'Some%3Cloremipsum%3E') and its subschema uses `oneOf`/`allOf`/`anyOf`, building fails with `can't resolve reference` from ajv.Root cause: the two resolvers disagree on how to interpret the
fragment. ajv (per the JSON Schema spec) percent-decodes the fragment before looking up the definitions key (`unescapeFragment` = `decodeURIComponent` + JSON-pointer unescape), while the internal serializer resolves refs literally. A key copied verbatim intomatches on the serializer side but misses on the ajv side.Solution
In
Validator.convertSchemaToAjvFormat, percent-decode thedefinitions/`` keys before handing the schema to ajv, so both resolvers agree:getState()now stores the converted schema, so the standalone-mode validator sees the same normalized keysTests
Added two tests in
test/ref.test.js: adefinitionskey with%3C/%3EplusoneOf, and a `` variant. Full suite passes (493 tests), types (12 assertions) and eslint clean.